Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 1210153008: Minor refactor to simplify code in content/test/test_content_client.cc (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
CC:
boliu, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor refactor to simplify code in content/test/test_content_client.cc Addresses review comments from caa7a3dddb27b19eb BUG=505538 Committed: https://crrev.com/b08c8e9d6ead84d218b055d31e5d728c3eb74476 Cr-Commit-Position: refs/heads/master@{#337393}

Patch Set 1 #

Patch Set 2 : fix ios compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M content/test/test_content_client.cc View 1 2 chunks +15 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
agrieve
5 years, 5 months ago (2015-06-30 19:31:01 UTC) #2
agrieve
jochen@chromium.org: Please review changes in
5 years, 5 months ago (2015-07-03 17:16:59 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-06 10:33:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210153008/1
5 years, 5 months ago (2015-07-06 13:44:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/84116)
5 years, 5 months ago (2015-07-06 13:51:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210153008/20001
5 years, 5 months ago (2015-07-06 14:04:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-06 14:50:55 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 14:51:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b08c8e9d6ead84d218b055d31e5d728c3eb74476
Cr-Commit-Position: refs/heads/master@{#337393}

Powered by Google App Engine
This is Rietveld 408576698