device_utils: Compute host and device md5s concurrently in PushChangedFiles

device_utils: Compute host and device md5s concurrently in PushChangedFiles

Time for a no-op push of chrome libs went from 2.1s -> 1.32s with this change.

BUG=

Committed: https://crrev.com/71374e5ea003d90d91252c2c2295702169dcc7cb
Cr-Commit-Position: refs/heads/master@{#352024}

[agrieve, 2015-09-25 14:13:52]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2015-09-25 14:14:04]

ptal

[jbudorick, 2015-09-25 14:20:45]

lgtm

[agrieve, 2015-09-25 14:42:52]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-09-25 14:43:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371563002/1

[commit-bot: I haz the power, 2015-09-25 19:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 19:17:54]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[agrieve, 2015-09-28 17:07:20]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-09-28 17:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371563002/1

[commit-bot: I haz the power, 2015-09-28 20:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 20:07:03]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[agrieve, 2015-09-29 15:05:03]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-09-29 15:05:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371563002/1

[commit-bot: I haz the power, 2015-09-29 18:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 18:59:37]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[jbudorick, 2015-09-29 19:14:54]

On 2015/09/29 at 18:59:37, commit-bot wrote:
> Try jobs failed on following builders:
>   linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

This is probably a legitimate failure in or around zip pushing. I can look into
it in EMEA morning if you don't solve it beforehand.

[agrieve, 2015-09-29 20:31:55]

On 2015/09/29 19:14:54, jbudorick wrote:
> On 2015/09/29 at 18:59:37, commit-bot wrote:
> > Try jobs failed on following builders:
> >   linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
> 
> This is probably a legitimate failure in or around zip pushing. I can look
into
> it in EMEA morning if you don't solve it beforehand.

Thanks for looking in! Figured it was legitimate, but had the time to wait for a
retry anyways.

Looks like the path changing part of it had extra "/foo/bar/./baz" in it (extra
dot).

Giving it another go!

[agrieve, 2015-09-30 02:42:39]

On 2015/09/29 20:31:55, agrieve wrote:
> On 2015/09/29 19:14:54, jbudorick wrote:
> > On 2015/09/29 at 18:59:37, commit-bot wrote:
> > > Try jobs failed on following builders:
> > >   linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
> > 
> > This is probably a legitimate failure in or around zip pushing. I can look
> into
> > it in EMEA morning if you don't solve it beforehand.
> 
> Thanks for looking in! Figured it was legitimate, but had the time to wait for
a
> retry anyways.
> 
> Looks like the path changing part of it had extra "/foo/bar/./baz" in it
(extra
> dot).
> 
> Giving it another go!

I believe I've tracked down the cause of the error:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/devi...

Since I'm moving the calculation to another thread, it's running under a timeout
of 30s instead of 300s.

Working on a fix.

[agrieve, 2015-10-02 03:48:46]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-02 03:49:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371563002/60001

[commit-bot: I haz the power, 2015-10-02 06:32:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-02 06:32:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[agrieve, 2015-10-02 12:24:36]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-10-02 12:24:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1371563002/#ps60001
(title: "rebase on dependent patch")

[commit-bot: I haz the power, 2015-10-02 12:25:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371563002/60001

[commit-bot: I haz the power, 2015-10-02 14:07:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-02 14:08:32]

Patchset 4 (id:??) landed as
https://crrev.com/71374e5ea003d90d91252c2c2295702169dcc7cb
Cr-Commit-Position: refs/heads/master@{#352024}