Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1372873003: DeviceUtils: Fix a couple of corner-cases when wrapping commands. (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device-utils-concurrent-md5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils: Fix a couple of corner-cases when wrapping commands. DeviceUtils.RunShellCommand() was missing ()s when wrapping, causing commands containing ;s to not work properly. AdbWrapper.py was missing a space after ()s, causing an error when the wrapped command begins with a (. This is because (( != ( (. BUG= Committed: https://crrev.com/c4d22ef711dee64e24e805eb6fe30c1121fc7178 Cr-Commit-Position: refs/heads/master@{#351412}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/android/devil/android/device_utils.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil/android/device_utils_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/devil/android/sdk/adb_wrapper.py View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
agrieve
On 2015/09/29 17:19:18, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org please review.
5 years, 2 months ago (2015-09-29 17:23:03 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/1372873003/diff/1/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1372873003/diff/1/build/android/devil/android/device_utils.py#newcode755 build/android/devil/android/device_utils.py:755: cmd = '( %s )>%s' % (cmd, large_output_file.name) ...
5 years, 2 months ago (2015-09-29 17:24:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372873003/20001
5 years, 2 months ago (2015-09-29 20:14:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 22:22:35 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 22:23:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4d22ef711dee64e24e805eb6fe30c1121fc7178
Cr-Commit-Position: refs/heads/master@{#351412}

Powered by Google App Engine
This is Rietveld 408576698