Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1388803002: Fix incremental_install breaking after clearing app data. (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incremental_install breaking after clearing app data. BUG=520082 Committed: https://crrev.com/63d84e11479090443b56959c27c68c86494dbfed Cr-Commit-Position: refs/heads/master@{#352402}

Patch Set 1 #

Patch Set 2 : split up cl #

Total comments: 2

Patch Set 3 : revert comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Dependent Patchsets:

Issue 1385893004 Patch 40001

Messages

Total messages: 13 (5 generated)
agrieve
On 2015/10/05 18:00:37, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org ptal
5 years, 2 months ago (2015-10-05 18:00:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388803002/1
5 years, 2 months ago (2015-10-05 18:16:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-05 18:47:38 UTC) #6
pkotwicz
LGTM! Much cleaner. Can you please update the CL description though? https://codereview.chromium.org/1388803002/diff/20001/build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java File build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java (left): ...
5 years, 2 months ago (2015-10-05 19:39:39 UTC) #7
agrieve
https://codereview.chromium.org/1388803002/diff/20001/build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java File build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java (left): https://codereview.chromium.org/1388803002/diff/20001/build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java#oldcode121 build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java:121: // https://code.google.com/p/android/issues/detail?id=79480 On 2015/10/05 19:39:39, pkotwicz wrote: > Did ...
5 years, 2 months ago (2015-10-05 19:45:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388803002/40001
5 years, 2 months ago (2015-10-05 19:48:01 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-05 20:15:33 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:17:13 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/63d84e11479090443b56959c27c68c86494dbfed
Cr-Commit-Position: refs/heads/master@{#352402}

Powered by Google App Engine
This is Rietveld 408576698