Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417823007: GN(Android): Fix up gl_tests to match GYP (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz, brettw
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(Android): Fix up gl_tests to match GYP BUG=510485 Committed: https://crrev.com/4c6168e5f82ffe41e17c5d8459b4f60721454d82 Cr-Commit-Position: refs/heads/master@{#355713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 8 (2 generated)
agrieve
5 years, 2 months ago (2015-10-22 20:13:53 UTC) #2
pkotwicz
lgtm
5 years, 2 months ago (2015-10-22 21:35:45 UTC) #3
brettw
lgtm
5 years, 2 months ago (2015-10-22 23:55:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417823007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417823007/1
5 years, 2 months ago (2015-10-23 02:25:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 02:56:04 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 02:56:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4c6168e5f82ffe41e17c5d8459b4f60721454d82
Cr-Commit-Position: refs/heads/master@{#355713}

Powered by Google App Engine
This is Rietveld 408576698