Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1392813002: GN Incremental Install: Reinstall apk regardless of cached values (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN Incremental Install: Reinstall apk regardless of cached values It sometimes happens that a dev will uninstall an app on device manually. This currently breaks incremental installs, because the DeviceUtils cache thinks the apk already exists. To fix this, verify that cached apk paths actually exist the first time a cached apk path value is used. BUG=520082 Committed: https://crrev.com/164d0c34c518d359c00099597f92ca967d863708 Cr-Commit-Position: refs/heads/master@{#352774}

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M build/android/devil/android/device_utils.py View 1 3 chunks +18 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
agrieve
On 2015/10/07 03:08:58, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org ptal. This actually ...
5 years, 2 months ago (2015-10-07 03:13:15 UTC) #2
jbudorick
lgtm
5 years, 2 months ago (2015-10-07 03:20:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392813002/20001
5 years, 2 months ago (2015-10-07 03:36:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 05:12:55 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 05:13:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/164d0c34c518d359c00099597f92ca967d863708
Cr-Commit-Position: refs/heads/master@{#352774}

Powered by Google App Engine
This is Rietveld 408576698