Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1405853003: Android gtest runner: When skipping test list, don't treat *s as failed. (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android gtest runner: When skipping test list, don't treat *s as failed. Fixes a bug recently introduced by http://crrev.com/065d746. "Foo.*" can now be a test name, so the test result gathering logic needs to be aware that this can happen. BUG=540857 Committed: https://crrev.com/81130db581553a67b98ef5feb259c3a05e326e64 Cr-Commit-Position: refs/heads/master@{#354268}

Patch Set 1 #

Patch Set 2 : Fix obvious bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M build/android/pylib/local/device/local_device_test_run.py View 1 2 chunks +10 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
agrieve
On 2015/10/15 01:31:26, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org ™
5 years, 2 months ago (2015-10-15 01:31:38 UTC) #2
jbudorick
lgtm
5 years, 2 months ago (2015-10-15 13:18:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405853003/20001
5 years, 2 months ago (2015-10-15 13:35:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 15:08:39 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 15:09:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81130db581553a67b98ef5feb259c3a05e326e64
Cr-Commit-Position: refs/heads/master@{#354268}

Powered by Google App Engine
This is Rietveld 408576698