Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1412123008: Android GTest Runner: Handle test filters that start / end with : (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android GTest Runner: Handle test filters that start / end with : Related to http://crrev.com/065d746. The test runner was crashing from empty test names that came from splitting on --gtest-filter "Fooo:", or "Foo::Bar" BUG=540857 Committed: https://crrev.com/016687edccdba8f6f778ff3cd5ae8c9c65d20b3d Cr-Commit-Position: refs/heads/master@{#355856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
agrieve
On 2015/10/22 19:53:49, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org ▣▣ ▣▣
5 years, 1 month ago (2015-10-23 15:58:37 UTC) #3
jbudorick
lgtm
5 years, 1 month ago (2015-10-23 15:59:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412123008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412123008/1
5 years, 1 month ago (2015-10-23 17:42:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-23 19:29:03 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-23 19:30:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/016687edccdba8f6f778ff3cd5ae8c9c65d20b3d
Cr-Commit-Position: refs/heads/master@{#355856}

Powered by Google App Engine
This is Rietveld 408576698