Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1402063002: GN: Fix host_forwarder when is_component=true (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix host_forwarder when is_component=true Creates a symlink rather than a copy so that it can find its dependent libraries. BUG=535322 Committed: https://crrev.com/d2287656e5f45343bdc4d083916183d30d873460 Cr-Commit-Position: refs/heads/master@{#354018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M tools/android/forwarder2/BUILD.gn View 3 chunks +16 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
agrieve
5 years, 2 months ago (2015-10-14 01:54:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402063002/1
5 years, 2 months ago (2015-10-14 02:49:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 03:21:31 UTC) #6
Yaron
lgtm
5 years, 2 months ago (2015-10-14 14:07:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402063002/1
5 years, 2 months ago (2015-10-14 14:11:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 14:54:32 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 14:56:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2287656e5f45343bdc4d083916183d30d873460
Cr-Commit-Position: refs/heads/master@{#354018}

Powered by Google App Engine
This is Rietveld 408576698