Make base::Value::TYPE a scoped enum.

Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

TBR=stevenjb@chromium.org
BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/dc72ee94d48e9a7db7e681c790fda82ece1bc3e2
Cr-Commit-Position: refs/heads/master@{#436961}

[jdoerrie, 2016-12-02 14:50:27]

Description was changed from

==========
git cl format


static_casts


Stream Operator


Type::DICTIONARY


Type::BINARY


Type::STRING


Type::DOUBLE


Type::INTEGER


Type::LIST


Type::BOOLEAN


Type::NONE


enum class

BUG=646113
==========

to

==========
git cl format


static_casts


Stream Operator


Type::DICTIONARY


Type::BINARY


Type::STRING


Type::DOUBLE


Type::INTEGER


Type::LIST


Type::BOOLEAN


Type::NONE


enum class

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jdoerrie, 2016-12-02 14:50:28]

Description was changed from

==========
git cl format


static_casts


Stream Operator


Type::DICTIONARY


Type::BINARY


Type::STRING


Type::DOUBLE


Type::INTEGER


Type::LIST


Type::BOOLEAN


Type::NONE


enum class

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
git cl format


static_casts


Stream Operator


Type::DICTIONARY


Type::BINARY


Type::STRING


Type::DOUBLE


Type::INTEGER


Type::LIST


Type::BOOLEAN


Type::NONE


enum class

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jdoerrie, 2016-12-02 14:50:31]

Description was changed from

==========
git cl format


static_casts


Stream Operator


Type::DICTIONARY


Type::BINARY


Type::STRING


Type::DOUBLE


Type::INTEGER


Type::LIST


Type::BOOLEAN


Type::NONE


enum class

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
git cl format


static_casts


Stream Operator


Type::DICTIONARY


Type::BINARY


Type::STRING


Type::DOUBLE


Type::INTEGER


Type::LIST


Type::BOOLEAN


Type::NONE


enum class

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jdoerrie, 2016-12-02 14:54:12]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 14:54:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 16:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:17:38]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[jdoerrie, 2016-12-06 09:46:04]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 09:46:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 12:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 12:09:19]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[jdoerrie, 2016-12-06 13:21:25]

Description was changed from

==========
git cl format


static_casts


Stream Operator


Type::DICTIONARY


Type::BINARY


Type::STRING


Type::DOUBLE


Type::INTEGER


Type::LIST


Type::BOOLEAN


Type::NONE


enum class

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.
==========

[jdoerrie, 2016-12-06 13:21:26]

jdoerrie@chromium.org changed reviewers:
+ brettw@chromium.org

[jdoerrie, 2016-12-06 13:22:22]

Summary of Changes
- The vast majority changes are a simple search and replace, executed via
  `sed -i "s/\bValue::TYPE_${TYPE}\b/Value::Type::${TYPE}/g"

- To change ${OUTDIR}/gen/components/policy/policy_constants.cc changes to
  components/policy/tools/generate_policy_source.py were needed.

- An ostream operator<< was added, so that logging code still compiles,
  examples are the following:
  - dbus/values_util.cc:85
  - components/json_schema/json_schema_validator.cc:370
  - components/prefs/pref_value_store.cc:250

- static_casts were added in the following files:
  - chromeos/geolocation/simple_geolocation_request.cc
  - chromeos/timezone/timezone_request.cc
  - extensions/common/extension_api.cc
  - ipc/ipc_message_utils.cc
  - tools/ipc_fuzzer/fuzzer/fuzzer.cc

- Commit hooks such as the `git cl format` requirement for base and chromeos and
  the 80 char line limit resulted in whitespace changes in these files:
  - base/json/json_parser.cc
  - base/values.cc
  - chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
  - chrome/browser/net/disk_cache_dir_policy_handler.cc
  - chrome/browser/policy/configuration_policy_handler_list_factory.cc
  - chromeos/network/network_state_unittest.cc
  - chromeos/network/onc/onc_signature.cc
  - chromeos/timezone/timezone_request.cc
  - components/prefs/pref_service.cc
  - components/safe_json/json_sanitizer.cc
  - components/search_engines/default_search_policy_handler.cc
  - components/translate/core/browser/translate_language_list.cc
  - content/renderer/java/gin_java_bridge_value_converter_unittest.cc
  - extensions/common/extension_api.cc


Remaining questions:
- Naming
  - Current naming of Type::BINARY breaks win_clang build:
    ```
      E:\b\c\b\win_clang\src\base\values.h(58,5):  error: expected identifier
        BINARY,
        ^
      <command line>(16,16):  note: expanded from here
      #define BINARY BINARY_CORE
                     ^
      <command line>(4,21):  note: expanded from here
      #define BINARY_CORE 1
                          ^
      1 error generated.
    ```,
    possible cause is remoting/host/predefines_win.gn
  - We already had to change TYPE_NULL to Type::NONE, given the NULL is a
    reserved keyword, should we rename CreateNullValue into CreateNoneValue?
  - Should we try to fix win_clang build, or rename BINARY to BLOB or similar?

- Underlying Type
  C++11 enum classes allow explicit specification of underlying type, defaults
  to int. We could use an (unsigned) char here, to save space under certain
  circumstances. Thoughts?

[brettw, 2016-12-06 18:12:51]

I was expecting some collision with STRING or INTEGER with the Windows headers,
but I don't see any. Yay!

But it looks like remoting defines "BINARY" in remoting/host/BUILD.gn which is
causing the error on the clang bot.

I think this is poor practice for the remoting component so I think we should
fix that rather than try to undef it in values.h.  Maybe REMOTING_HOST_BINARY?
(Probably should check with the remoting team). On the plus side it's only used
a couple of times.

[brettw, 2016-12-06 18:15:14]

(I'd do the remoting thing in a separate patch and then try to land this.

I spot checked and this patch LGTM when the BINARY issue is fixed.

[jdoerrie, 2016-12-07 08:20:39]

Description was changed from

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
==========

[jdoerrie, 2016-12-07 11:36:22]

Description was changed from

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jdoerrie, 2016-12-07 11:36:23]

Description was changed from

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jdoerrie, 2016-12-07 11:36:23]

Description was changed from

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jdoerrie, 2016-12-07 11:37:03]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 11:37:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2016-12-07 14:42:35]

Description was changed from

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

TBR=stevenjb@chromium.org
BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jdoerrie, 2016-12-07 14:42:35]

jdoerrie@chromium.org changed reviewers:
+ mkwst@chromium.org, stevenjb@chromium.org

[jdoerrie, 2016-12-07 14:46:26]

Hey Mike, could you please review
components/arc/bluetooth/bluetooth_type_converters_unittest.cc?


For the rest I am using TBR, because this change is largely mechanical, Brett
already gave his LGTM and the effort was published on chromium-dev in
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/qWyLUZklfCk/UGrvL....

[Mike West, 2016-12-07 14:48:01]

Mechanical changes to `bluetooth_type_converters_unittest.cc` LGTM.

[commit-bot: I haz the power, 2016-12-07 15:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 15:28:48]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2016-12-07 15:30:57]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2016-12-07 15:30:58]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2539363004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-07 15:31:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 15:43:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481124657606140,
"parent_rev": "b4b1ab2c9e18f78a71c39dd935d6e1a90a7b6e8e", "commit_rev":
"5af1b7a8d63056de514edd6246acff186389658e"}

[commit-bot: I haz the power, 2016-12-07 15:44:04]

Description was changed from

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

TBR=stevenjb@chromium.org
BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

TBR=stevenjb@chromium.org
BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-12-07 15:44:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-07 15:47:02]

Description was changed from

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

TBR=stevenjb@chromium.org
BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Make base::Value::TYPE a scoped enum.

As mentioned in the base::Value refactor proposal, base::Value::Type should be a
C++11 style scoped enumeration. This change addresses this issue by adding the
required keyword, making the necessary substitutions and adding casts where
needed.

TBR=stevenjb@chromium.org
BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/dc72ee94d48e9a7db7e681c790fda82ece1bc3e2
Cr-Commit-Position: refs/heads/master@{#436961}
==========

[commit-bot: I haz the power, 2016-12-07 15:47:06]

Patchset 3 (id:??) landed as
https://crrev.com/dc72ee94d48e9a7db7e681c790fda82ece1bc3e2
Cr-Commit-Position: refs/heads/master@{#436961}