chrome/browser/ui/webui/nacl_ui.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/nacl_ui.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/nacl_ui.cc

diff --git a/chrome/browser/ui/webui/nacl_ui.cc b/chrome/browser/ui/webui/nacl_ui.cc

index f3713b2c461a7535ba833be172f1d17b596a16ba..7fb1ea65bf577ad6d7d9bdfda7747fcd8b02992d 100644

--- a/chrome/browser/ui/webui/nacl_ui.cc

+++ b/chrome/browser/ui/webui/nacl_ui.cc

@@ -335,7 +335,7 @@ void CheckVersion(const base::FilePath& pnacl_path, std::string* version) {

JSONFileValueDeserializer deserializer(pnacl_json_path);

std::string error;

std::unique_ptr<base::Value> root = deserializer.Deserialize(NULL, &error);

- if (!root || !root->IsType(base::Value::TYPE_DICTIONARY))

+ if (!root || !root->IsType(base::Value::Type::DICTIONARY))

return;

// Now try to get the field. This may leave version empty if the