Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Unified Diff: chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc b/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
index 9587dbd96b8b18f4e576f78fafb69af2957841f9..6d310f4374b5056006063a6b514c9b1126a64bc3 100644
--- a/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
+++ b/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
@@ -160,7 +160,7 @@ TEST_F(SyncConfirmationHandlerTest, TestSetImageIfPrimaryAccountReady) {
EXPECT_EQ("sync.confirmation.setUserImageURL",
web_ui()->call_data()[0]->function_name());
EXPECT_TRUE(
- web_ui()->call_data()[0]->arg1()->IsType(base::Value::TYPE_STRING));
+ web_ui()->call_data()[0]->arg1()->IsType(base::Value::Type::STRING));
std::string passed_picture_url;
EXPECT_TRUE(
web_ui()->call_data()[0]->arg1()->GetAsString(&passed_picture_url));
@@ -204,7 +204,7 @@ TEST_F(SyncConfirmationHandlerTest, TestSetImageIfPrimaryAccountReadyLater) {
EXPECT_EQ("sync.confirmation.setUserImageURL",
web_ui()->call_data()[1]->function_name());
EXPECT_TRUE(
- web_ui()->call_data()[1]->arg1()->IsType(base::Value::TYPE_STRING));
+ web_ui()->call_data()[1]->arg1()->IsType(base::Value::Type::STRING));
std::string passed_picture_url;
EXPECT_TRUE(
web_ui()->call_data()[1]->arg1()->GetAsString(&passed_picture_url));
« no previous file with comments | « chrome/browser/ui/webui/settings/certificates_handler.cc ('k') | chrome/common/cloud_print/cloud_print_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698