Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: chrome/browser/plugins/plugin_finder_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/plugins/plugin_finder.h" 5 #include "chrome/browser/plugins/plugin_finder.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/plugins/plugin_metadata.h" 8 #include "chrome/browser/plugins/plugin_metadata.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 using base::DictionaryValue; 11 using base::DictionaryValue;
12 using base::ListValue; 12 using base::ListValue;
13 13
14 TEST(PluginFinderTest, JsonSyntax) { 14 TEST(PluginFinderTest, JsonSyntax) {
15 std::unique_ptr<base::DictionaryValue> plugin_list( 15 std::unique_ptr<base::DictionaryValue> plugin_list(
16 PluginFinder::LoadBuiltInPluginList()); 16 PluginFinder::LoadBuiltInPluginList());
17 ASSERT_TRUE(plugin_list.get()); 17 ASSERT_TRUE(plugin_list.get());
18 std::unique_ptr<base::Value> version; 18 std::unique_ptr<base::Value> version;
19 ASSERT_TRUE(plugin_list->Remove("x-version", &version)); 19 ASSERT_TRUE(plugin_list->Remove("x-version", &version));
20 EXPECT_EQ(base::Value::TYPE_INTEGER, version->GetType()); 20 EXPECT_EQ(base::Value::Type::INTEGER, version->GetType());
21 21
22 for (base::DictionaryValue::Iterator plugin_it(*plugin_list); 22 for (base::DictionaryValue::Iterator plugin_it(*plugin_list);
23 !plugin_it.IsAtEnd(); plugin_it.Advance()) { 23 !plugin_it.IsAtEnd(); plugin_it.Advance()) {
24 const base::DictionaryValue* plugin = NULL; 24 const base::DictionaryValue* plugin = NULL;
25 ASSERT_TRUE(plugin_it.value().GetAsDictionary(&plugin)); 25 ASSERT_TRUE(plugin_it.value().GetAsDictionary(&plugin));
26 std::string dummy_str; 26 std::string dummy_str;
27 bool dummy_bool; 27 bool dummy_bool;
28 if (plugin->HasKey("lang")) 28 if (plugin->HasKey("lang"))
29 EXPECT_TRUE(plugin->GetString("lang", &dummy_str)); 29 EXPECT_TRUE(plugin->GetString("lang", &dummy_str));
30 if (plugin->HasKey("url")) 30 if (plugin->HasKey("url"))
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 EXPECT_TRUE(version_dict->GetString("version", &dummy_str)); 63 EXPECT_TRUE(version_dict->GetString("version", &dummy_str));
64 std::string status_str; 64 std::string status_str;
65 EXPECT_TRUE(version_dict->GetString("status", &status_str)); 65 EXPECT_TRUE(version_dict->GetString("status", &status_str));
66 PluginMetadata::SecurityStatus status = 66 PluginMetadata::SecurityStatus status =
67 PluginMetadata::SECURITY_STATUS_UP_TO_DATE; 67 PluginMetadata::SECURITY_STATUS_UP_TO_DATE;
68 EXPECT_TRUE(PluginMetadata::ParseSecurityStatus(status_str, &status)) 68 EXPECT_TRUE(PluginMetadata::ParseSecurityStatus(status_str, &status))
69 << "Invalid security status \"" << status_str << "\""; 69 << "Invalid security status \"" << status_str << "\"";
70 } 70 }
71 } 71 }
72 } 72 }
OLDNEW
« no previous file with comments | « chrome/browser/plugins/plugin_finder.cc ('k') | chrome/browser/plugins/plugin_policy_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698