Make base::Value::TYPE a scoped enum.

tools/json_schema_compiler/cpp_util.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utilies and constants specific to Chromium C++ code.
 """
 
 from code import Code
 from datetime import datetime
 from model import PropertyType
@@ skipping 42 matching lines @@
       PropertyType.DOUBLE: '%s->GetAsDouble(%s)',
       PropertyType.INTEGER: '%s->GetAsInteger(%s)',
       PropertyType.STRING: '%s->GetAsString(%s)',
   }[type_.property_type] % (src, dst)
 
 
 def GetValueType(type_):
   """Returns the Value::Type corresponding to the model.Type.
   """
   return {
-      PropertyType.ARRAY: 'base::Value::TYPE_LIST',
-      PropertyType.BINARY: 'base::Value::TYPE_BINARY',
-      PropertyType.BOOLEAN: 'base::Value::TYPE_BOOLEAN',
+      PropertyType.ARRAY: 'base::Value::Type::LIST',
+      PropertyType.BINARY: 'base::Value::Type::BINARY',
+      PropertyType.BOOLEAN: 'base::Value::Type::BOOLEAN',
       # PropertyType.CHOICES can be any combination of types.
-      PropertyType.DOUBLE: 'base::Value::TYPE_DOUBLE',
-      PropertyType.ENUM: 'base::Value::TYPE_STRING',
-      PropertyType.FUNCTION: 'base::Value::TYPE_DICTIONARY',
-      PropertyType.INTEGER: 'base::Value::TYPE_INTEGER',
-      PropertyType.OBJECT: 'base::Value::TYPE_DICTIONARY',
-      PropertyType.STRING: 'base::Value::TYPE_STRING',
+      PropertyType.DOUBLE: 'base::Value::Type::DOUBLE',
+      PropertyType.ENUM: 'base::Value::Type::STRING',
+      PropertyType.FUNCTION: 'base::Value::Type::DICTIONARY',
+      PropertyType.INTEGER: 'base::Value::Type::INTEGER',
+      PropertyType.OBJECT: 'base::Value::Type::DICTIONARY',
+      PropertyType.STRING: 'base::Value::Type::STRING',
   }[type_.property_type]
 
 
 def GetParameterDeclaration(param, type_):
   """Gets a parameter declaration of a given model.Property and its C++
   type.
   """
   if param.type_.property_type in (PropertyType.ANY,
                                    PropertyType.ARRAY,
                                    PropertyType.BINARY,
@@ skipping 69 matching lines @@
   has been passed as a flag to compiler.py from GYP/GN.
   '''
   # For some reason Windows builds escape the % characters, so unescape them.
   # This means that %% can never appear legitimately within a pattern, but
   # that's ok. It should never happen.
   cpp_namespace = pattern.replace('%%', '%') % { 'namespace': namespace }
   assert '%' not in cpp_namespace, \
          ('Did not manage to fully substitute namespace "%s" into pattern "%s"'
            % (namespace, pattern))
   return cpp_namespace