Make base::Value::TYPE a scoped enum.

chrome/browser/banners/app_banner_settings_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 336 matching lines @@
   base::ListValue* could_show_list = nullptr;
   if (!app_dict->GetList(event_key, &could_show_list)) {
     could_show_list = new base::ListValue();
     app_dict->Set(event_key, base::WrapUnique(could_show_list));
   }
 
   // Trim any items that are older than we should care about. For comparisons
   // the times are converted to local dates.
   base::Time date = BucketTimeToResolution(time, gMinimumMinutesBetweenVisits);
   for (auto it = could_show_list->begin(); it != could_show_list->end();) {
-    if ((*it)->IsType(base::Value::TYPE_DICTIONARY)) {
+    if ((*it)->IsType(base::Value::Type::DICTIONARY)) {
       base::DictionaryValue* internal_value;
       double internal_date;
       (*it)->GetAsDictionary(&internal_value);
 
       if (internal_value->GetDouble(kBannerTimeKey, &internal_date)) {
         base::Time other_date =
             BucketTimeToResolution(base::Time::FromInternalValue(internal_date),
                                    gMinimumMinutesBetweenVisits);
         if (other_date == date) {
           double other_engagement = 0;
@@ skipping 121 matching lines @@
       GetAppDict(origin_dict.get(), package_name_or_start_url);
   if (!app_dict)
     return result;
 
   std::string event_key(kBannerEventKeys[APP_BANNER_EVENT_COULD_SHOW]);
   base::ListValue* could_show_list = nullptr;
   if (!app_dict->GetList(event_key, &could_show_list))
     return result;
 
   for (const auto& value : *could_show_list) {
-    if (value->IsType(base::Value::TYPE_DICTIONARY)) {
+    if (value->IsType(base::Value::Type::DICTIONARY)) {
       base::DictionaryValue* internal_value;
       double internal_date = 0;
       value->GetAsDictionary(&internal_value);
       double engagement = 0;
 
       if (internal_value->GetDouble(kBannerTimeKey, &internal_date) &&
           internal_value->GetDouble(kBannerEngagementKey, &engagement)) {
         base::Time date = base::Time::FromInternalValue(internal_date);
         result.push_back({date, engagement});
       }
@@ skipping 64 matching lines @@
       GetOriginDict(settings, origin_url);
 
   if (!origin_dict)
     return false;
 
   // Iterate over everything in the content setting, which should be a set of
   // dictionaries per app path. If we find one that has been added to
   // homescreen recently, return true.
   for (base::DictionaryValue::Iterator it(*origin_dict); !it.IsAtEnd();
        it.Advance()) {
-    if (it.value().IsType(base::Value::TYPE_DICTIONARY)) {
+    if (it.value().IsType(base::Value::Type::DICTIONARY)) {
       const base::DictionaryValue* value;
       it.value().GetAsDictionary(&value);
 
       std::string event_key(
           kBannerEventKeys[APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN]);
       double internal_time;
       if (it.key() == kInstantAppsKey ||
           !value->GetDouble(event_key, &internal_time)) {
         continue;
       }
@@ skipping 101 matching lines @@
     return true;
   }
 
   // Assume any value which is not "0" or "false" indicates that we should use
   // site engagement.
   std::string param = variations::GetVariationParamValue(
       kBannerParamsKey, kBannerSiteEngagementParamsKey);
 
   return (!param.empty() && param != "0" && param != "false");
 }