chrome/browser/extensions/external_provider_impl.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_provider_impl.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_provider_impl.cc

diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc

index 6d6dba08b0c0dd6a548ee9c3042c4f16ae18d81c..aa4cc325e4769bb9d5c7e1fa3642a92650a0ae61 100644

--- a/chrome/browser/extensions/external_provider_impl.cc

+++ b/chrome/browser/extensions/external_provider_impl.cc

@@ -211,7 +211,7 @@ void ExternalProviderImpl::RetrieveExtensionsFromPrefs(

bool has_external_version = false;

if (extension->Get(kExternalVersion, &external_version_value)) {

- if (external_version_value->IsType(base::Value::TYPE_STRING)) {

+ if (external_version_value->IsType(base::Value::Type::STRING)) {

external_version_value->GetAsString(&external_version);

has_external_version = true;

} else {