Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/renderer/extensions/cast_streaming_native_handler.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/uninstall_metrics.cc ('k') | chrome/test/base/extension_js_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/cast_streaming_native_handler.cc
diff --git a/chrome/renderer/extensions/cast_streaming_native_handler.cc b/chrome/renderer/extensions/cast_streaming_native_handler.cc
index 6f504ac583783d6b36c4fd83427e1751aae816e2..38ab2ae7408a3acac7fb5e813348139a593be654 100644
--- a/chrome/renderer/extensions/cast_streaming_native_handler.cc
+++ b/chrome/renderer/extensions/cast_streaming_native_handler.cc
@@ -936,7 +936,7 @@ void CastStreamingNativeHandler::StartCastRtpReceiver(
std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
std::unique_ptr<base::Value> options_value(
converter->FromV8Value(args[8], context()->v8_context()));
- if (!options_value->IsType(base::Value::TYPE_NULL)) {
+ if (!options_value->IsType(base::Value::Type::NONE)) {
options = base::DictionaryValue::From(std::move(options_value));
if (!options) {
args.GetIsolate()->ThrowException(v8::Exception::TypeError(
« no previous file with comments | « chrome/installer/util/uninstall_metrics.cc ('k') | chrome/test/base/extension_js_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698