Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: content/common/android/gin_java_bridge_value.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl_unittest.cc ('k') | content/public/child/v8_value_converter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/android/gin_java_bridge_value.cc
diff --git a/content/common/android/gin_java_bridge_value.cc b/content/common/android/gin_java_bridge_value.cc
index 6a7423055fca2c3755605d992aee9c300f53320c..5961461457ef6ce9222313b6b8cc00bcad7ada7f 100644
--- a/content/common/android/gin_java_bridge_value.cc
+++ b/content/common/android/gin_java_bridge_value.cc
@@ -55,7 +55,7 @@ std::unique_ptr<base::BinaryValue> GinJavaBridgeValue::CreateObjectIDValue(
// static
bool GinJavaBridgeValue::ContainsGinJavaBridgeValue(const base::Value* value) {
- if (!value->IsType(base::Value::TYPE_BINARY))
+ if (!value->IsType(base::Value::Type::BINARY))
return false;
const base::BinaryValue* binary_value =
reinterpret_cast<const base::BinaryValue*>(value);
@@ -74,7 +74,7 @@ bool GinJavaBridgeValue::ContainsGinJavaBridgeValue(const base::Value* value) {
std::unique_ptr<const GinJavaBridgeValue> GinJavaBridgeValue::FromValue(
const base::Value* value) {
return std::unique_ptr<const GinJavaBridgeValue>(
- value->IsType(base::Value::TYPE_BINARY)
+ value->IsType(base::Value::Type::BINARY)
? new GinJavaBridgeValue(
reinterpret_cast<const base::BinaryValue*>(value))
: NULL);
« no previous file with comments | « content/child/v8_value_converter_impl_unittest.cc ('k') | content/public/child/v8_value_converter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698