components/content_settings/core/browser/content_settings_policy_provider.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_policy_provider.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_codec_unittest.cc ('k') | components/content_settings/core/browser/content_settings_pref.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_policy_provider.cc

diff --git a/components/content_settings/core/browser/content_settings_policy_provider.cc b/components/content_settings/core/browser/content_settings_policy_provider.cc

index 78a12a27a916aa1eb40423267b135fc905725751..8a7587ba070bceb627f392fea8141f1c52aef837 100644

--- a/components/content_settings/core/browser/content_settings_policy_provider.cc

+++ b/components/content_settings/core/browser/content_settings_policy_provider.cc

@@ -300,7 +300,7 @@ void PolicyProvider::GetAutoSelectCertificateSettingsFromPreferences(

std::unique_ptr<base::Value> value = base::JSONReader::Read(

pattern_filter_json, base::JSON_ALLOW_TRAILING_COMMAS);

- if (!value || !value->IsType(base::Value::TYPE_DICTIONARY)) {

+ if (!value || !value->IsType(base::Value::Type::DICTIONARY)) {

VLOG(1) << "Ignoring invalid certificate auto select setting. Reason:"

" Invalid JSON object: " << pattern_filter_json;

continue;