chrome/browser/devtools/devtools_window.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index a09046225c6c495300f1659b6601fcee43ea3bd8..0b2824f2e8dd29895304ce6cd342cffbf215f29e 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -101,7 +101,7 @@ void SetPreferencesFromJson(Profile* profile, const std::string& json) {

return;

DictionaryPrefUpdate update(profile->GetPrefs(), prefs::kDevToolsPreferences);

for (base::DictionaryValue::Iterator it(*dict); !it.IsAtEnd(); it.Advance()) {

- if (!it.value().IsType(base::Value::TYPE_STRING))

+ if (!it.value().IsType(base::Value::Type::STRING))

continue;

update.Get()->SetWithoutPathExpansion(

it.key(), it.value().CreateDeepCopy());