Make base::Value::TYPE a scoped enum.

extensions/renderer/activity_log_converter_strategy_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/activity_log_converter_strategy.h"
 
 #include <memory>
 
 #include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 15 matching lines @@
   void SetUp() override {
     converter_.reset(V8ValueConverter::create());
     strategy_.reset(new ActivityLogConverterStrategy());
     converter_->SetFunctionAllowed(true);
     converter_->SetStrategy(strategy_.get());
   }
 
   testing::AssertionResult VerifyNull(v8::Local<v8::Value> v8_value) {
     std::unique_ptr<base::Value> value(
         converter_->FromV8Value(v8_value, context()));
-    if (value->IsType(base::Value::TYPE_NULL))
+    if (value->IsType(base::Value::Type::NONE))
       return testing::AssertionSuccess();
     return testing::AssertionFailure();
   }
 
   testing::AssertionResult VerifyBoolean(v8::Local<v8::Value> v8_value,
                                          bool expected) {
     bool out;
     std::unique_ptr<base::Value> value(
         converter_->FromV8Value(v8_value, context()));
-    if (value->IsType(base::Value::TYPE_BOOLEAN)
+    if (value->IsType(base::Value::Type::BOOLEAN)
         && value->GetAsBoolean(&out)
         && out == expected)
       return testing::AssertionSuccess();
     return testing::AssertionFailure();
   }
 
   testing::AssertionResult VerifyInteger(v8::Local<v8::Value> v8_value,
                                          int expected) {
     int out;
     std::unique_ptr<base::Value> value(
         converter_->FromV8Value(v8_value, context()));
-    if (value->IsType(base::Value::TYPE_INTEGER)
+    if (value->IsType(base::Value::Type::INTEGER)
         && value->GetAsInteger(&out)
         && out == expected)
       return testing::AssertionSuccess();
     return testing::AssertionFailure();
   }
 
   testing::AssertionResult VerifyDouble(v8::Local<v8::Value> v8_value,
                                         double expected) {
     double out;
     std::unique_ptr<base::Value> value(
         converter_->FromV8Value(v8_value, context()));
-    if (value->IsType(base::Value::TYPE_DOUBLE)
+    if (value->IsType(base::Value::Type::DOUBLE)
         && value->GetAsDouble(&out)
         && out == expected)
       return testing::AssertionSuccess();
     return testing::AssertionFailure();
   }
 
   testing::AssertionResult VerifyString(v8::Local<v8::Value> v8_value,
                                         const std::string& expected) {
     std::string out;
     std::unique_ptr<base::Value> value(
         converter_->FromV8Value(v8_value, context()));
-    if (value->IsType(base::Value::TYPE_STRING)
+    if (value->IsType(base::Value::Type::STRING)
         && value->GetAsString(&out)
         && out == expected)
       return testing::AssertionSuccess();
     return testing::AssertionFailure();
   }
 
   v8::Local<v8::Context> context() const {
     return v8::Local<v8::Context>::New(isolate_, context_);
   }
 
@@ skipping 72 matching lines @@
       "[Array]"));
   EXPECT_TRUE(VerifyString(
       v8_object->Get(v8::String::NewFromUtf8(isolate_, "function")),
       "[Function]"));
   EXPECT_TRUE(VerifyString(
       v8_object->Get(v8::String::NewFromUtf8(isolate_, "named_function")),
       "[Function foo()]"));
 }
 
 }  // namespace extensions