Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: content/browser/webrtc/webrtc_internals_browsertest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webrtc/webrtc_internals_browsertest.cc
diff --git a/content/browser/webrtc/webrtc_internals_browsertest.cc b/content/browser/webrtc/webrtc_internals_browsertest.cc
index 046fbf8095f62645402448fce2933a05a446f5d7..c3fcbd50031ae7a185af106c94342d9784daf0ed 100644
--- a/content/browser/webrtc/webrtc_internals_browsertest.cc
+++ b/content/browser/webrtc/webrtc_internals_browsertest.cc
@@ -239,7 +239,7 @@ class MAYBE_WebRtcInternalsBrowserTest: public ContentBrowserTest {
std::unique_ptr<base::Value> value_requests =
base::JSONReader::Read(json_requests);
- EXPECT_EQ(base::Value::TYPE_LIST, value_requests->GetType());
+ EXPECT_EQ(base::Value::Type::LIST, value_requests->GetType());
base::ListValue* list_request =
static_cast<base::ListValue*>(value_requests.get());
@@ -439,7 +439,7 @@ class MAYBE_WebRtcInternalsBrowserTest: public ContentBrowserTest {
int update_number,
int stats_number) {
EXPECT_NE((base::Value*)NULL, dump);
- EXPECT_EQ(base::Value::TYPE_DICTIONARY, dump->GetType());
+ EXPECT_EQ(base::Value::Type::DICTIONARY, dump->GetType());
base::DictionaryValue* dict_dump =
static_cast<base::DictionaryValue*>(dump);
@@ -449,7 +449,7 @@ class MAYBE_WebRtcInternalsBrowserTest: public ContentBrowserTest {
for (; !it.IsAtEnd(); it.Advance()) {
base::Value* value = NULL;
dict_dump->Get(it.key(), &value);
- EXPECT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
+ EXPECT_EQ(base::Value::Type::DICTIONARY, value->GetType());
base::DictionaryValue* pc_dump =
static_cast<base::DictionaryValue*>(value);
EXPECT_TRUE(pc_dump->HasKey("updateLog"));
@@ -457,13 +457,13 @@ class MAYBE_WebRtcInternalsBrowserTest: public ContentBrowserTest {
// Verifies the number of updates.
pc_dump->Get("updateLog", &value);
- EXPECT_EQ(base::Value::TYPE_LIST, value->GetType());
+ EXPECT_EQ(base::Value::Type::LIST, value->GetType());
base::ListValue* list = static_cast<base::ListValue*>(value);
EXPECT_EQ((size_t) update_number, list->GetSize());
// Verifies the number of stats tables.
pc_dump->Get("stats", &value);
- EXPECT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
+ EXPECT_EQ(base::Value::Type::DICTIONARY, value->GetType());
base::DictionaryValue* dict = static_cast<base::DictionaryValue*>(value);
EXPECT_EQ((size_t) stats_number, dict->size());
}
@@ -477,7 +477,7 @@ class MAYBE_WebRtcInternalsBrowserTest: public ContentBrowserTest {
const string& report_id,
const StatsUnit& stats) {
EXPECT_NE((base::Value*)NULL, dump);
- EXPECT_EQ(base::Value::TYPE_DICTIONARY, dump->GetType());
+ EXPECT_EQ(base::Value::Type::DICTIONARY, dump->GetType());
base::DictionaryValue* dict_dump =
static_cast<base::DictionaryValue*>(dump);
@@ -488,7 +488,7 @@ class MAYBE_WebRtcInternalsBrowserTest: public ContentBrowserTest {
// Verifies there is one data series per stats name.
value = NULL;
pc_dump->Get("stats", &value);
- EXPECT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
+ EXPECT_EQ(base::Value::Type::DICTIONARY, value->GetType());
base::DictionaryValue* dataSeries =
static_cast<base::DictionaryValue*>(value);
« no previous file with comments | « content/browser/webrtc/webrtc_getusermedia_browsertest.cc ('k') | content/browser/webui/web_ui_data_source_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698