Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2886)

Unified Diff: chrome/browser/themes/browser_theme_pack_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/themes/browser_theme_pack_unittest.cc
diff --git a/chrome/browser/themes/browser_theme_pack_unittest.cc b/chrome/browser/themes/browser_theme_pack_unittest.cc
index 287d6ce18e383997cf38b10b8de97e09578da6fa..f31dc4ee119e5aba8bfaf1ac822e610f583f07ee 100644
--- a/chrome/browser/themes/browser_theme_pack_unittest.cc
+++ b/chrome/browser/themes/browser_theme_pack_unittest.cc
@@ -99,7 +99,7 @@ class BrowserThemePackTest : public ::testing::Test {
void LoadColorJSON(const std::string& json) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
- ASSERT_TRUE(value->IsType(base::Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsType(base::Value::Type::DICTIONARY));
LoadColorDictionary(static_cast<base::DictionaryValue*>(value.get()));
}
@@ -109,7 +109,7 @@ class BrowserThemePackTest : public ::testing::Test {
void LoadTintJSON(const std::string& json) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
- ASSERT_TRUE(value->IsType(base::Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsType(base::Value::Type::DICTIONARY));
LoadTintDictionary(static_cast<base::DictionaryValue*>(value.get()));
}
@@ -119,7 +119,7 @@ class BrowserThemePackTest : public ::testing::Test {
void LoadDisplayPropertiesJSON(const std::string& json) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
- ASSERT_TRUE(value->IsType(base::Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsType(base::Value::Type::DICTIONARY));
LoadDisplayPropertiesDictionary(
static_cast<base::DictionaryValue*>(value.get()));
}
@@ -131,7 +131,7 @@ class BrowserThemePackTest : public ::testing::Test {
void ParseImageNamesJSON(const std::string& json,
TestFilePathMap* out_file_paths) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
- ASSERT_TRUE(value->IsType(base::Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsType(base::Value::Type::DICTIONARY));
ParseImageNamesDictionary(static_cast<base::DictionaryValue*>(value.get()),
out_file_paths);
}
« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | chrome/browser/ui/app_list/search/common/json_response_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698