chromeos/network/onc/onc_validator.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_validator.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_validator.cc

diff --git a/chromeos/network/onc/onc_validator.cc b/chromeos/network/onc/onc_validator.cc

index dec7cfb8cf49f1ada0f5cc0b143972ce7dc1bc9f..db6efd01244e1dd885703210c9ce34ff21c80846 100644

--- a/chromeos/network/onc/onc_validator.cc

+++ b/chromeos/network/onc/onc_validator.cc

@@ -258,7 +258,7 @@ bool Validator::ValidateRecommendedField(

found_error = true;

error_cause = "unknown";

} else if (field_signature->value_signature->onc_type ==

- base::Value::TYPE_DICTIONARY) {

+ base::Value::Type::DICTIONARY) {

found_error = true;

error_cause = "dictionary-typed";

}