components/safe_json/testing_json_parser_unittest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_json/testing_json_parser_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_json/testing_json_parser_unittest.cc

diff --git a/components/safe_json/testing_json_parser_unittest.cc b/components/safe_json/testing_json_parser_unittest.cc

index 1e944a98fa2fbdd4e88a9b3c64055216f6ce1a6a..63f638fa09490efaabfe972cfb288995121ff333 100644

--- a/components/safe_json/testing_json_parser_unittest.cc

+++ b/components/safe_json/testing_json_parser_unittest.cc

@@ -40,7 +40,7 @@ class TestingJsonParserTest : public testing::Test {

test->did_success_ = true;

quit_closure.Run();

- ASSERT_TRUE(value->IsType(base::Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(value->IsType(base::Value::Type::DICTIONARY));

base::DictionaryValue* dict;

ASSERT_TRUE(value->GetAsDictionary(&dict));

int key_value = 0;