base/test/trace_event_analyzer_unittest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_event_analyzer_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/trace_event_analyzer_unittest.cc

diff --git a/base/test/trace_event_analyzer_unittest.cc b/base/test/trace_event_analyzer_unittest.cc

index 086cfc97d343bef7ab979a92e054f91e890c943a..caa35e280e2a5e8b648ab3f71779583ecaaea76b 100644

--- a/base/test/trace_event_analyzer_unittest.cc

+++ b/base/test/trace_event_analyzer_unittest.cc

@@ -123,7 +123,7 @@ TEST_F(TraceEventAnalyzerTest, TraceEvent) {

std::unique_ptr<base::Value> arg;

EXPECT_TRUE(event.GetArgAsValue("dict", &arg));

- EXPECT_EQ(base::Value::TYPE_DICTIONARY, arg->GetType());

+ EXPECT_EQ(base::Value::Type::DICTIONARY, arg->GetType());

}

TEST_F(TraceEventAnalyzerTest, QueryEventMember) {

« no previous file with comments | « base/test/trace_event_analyzer.cc ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »