Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: headless/lib/browser/devtools_api/domain_cc.template

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.cc ('k') | headless/public/domains/types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/devtools_api/domain_cc.template
diff --git a/headless/lib/browser/devtools_api/domain_cc.template b/headless/lib/browser/devtools_api/domain_cc.template
index 3345a4ad565a73e0291f7c92ed61cab543d04bc1..dc04d6e9d7bc2f7cb4a0613a6c89520055aa2564 100644
--- a/headless/lib/browser/devtools_api/domain_cc.template
+++ b/headless/lib/browser/devtools_api/domain_cc.template
@@ -103,7 +103,7 @@ void Domain::Handle{{method_name}}Response(base::Callback<void(std::unique_ptr<{
if (callback.is_null())
return;
// This is an error response.
- if (response.IsType(base::Value::TYPE_NULL)) {
+ if (response.IsType(base::Value::Type::NONE)) {
callback.Run(nullptr);
return;
}
« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.cc ('k') | headless/public/domains/types_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698