chrome/browser/extensions/api/settings_private/settings_private_api.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_private/settings_private_api.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_private/prefs_util.cc ('k') | chrome/browser/extensions/api/settings_private/settings_private_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_private/settings_private_api.cc

diff --git a/chrome/browser/extensions/api/settings_private/settings_private_api.cc b/chrome/browser/extensions/api/settings_private/settings_private_api.cc

index a73f78f8d83ec10f2d3534241ad4330aad743ef3..64104da47cbf7a82687851a3f02022dd605293d4 100644

--- a/chrome/browser/extensions/api/settings_private/settings_private_api.cc

+++ b/chrome/browser/extensions/api/settings_private/settings_private_api.cc

@@ -99,7 +99,7 @@ ExtensionFunction::ResponseAction SettingsPrivateGetPrefFunction::Run() {

return RespondNow(Error(kDelegateIsNull));

std::unique_ptr<base::Value> value = delegate->GetPref(parameters->name);

- if (value->IsType(base::Value::TYPE_NULL))

+ if (value->IsType(base::Value::Type::NONE))

return RespondNow(Error("Pref * does not exist", parameters->name));

else

return RespondNow(OneArgument(std::move(value)));