Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/common/extensions/manifest_handlers/theme_handler.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/theme_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/theme_handler.cc b/chrome/common/extensions/manifest_handlers/theme_handler.cc
index cdee0c3f15f828912fe308e03e0ae22c779de94d..99106c9d9e6fc1635033825d145a929aaa30d4e4 100644
--- a/chrome/common/extensions/manifest_handlers/theme_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/theme_handler.cc
@@ -32,12 +32,12 @@ bool LoadImages(const base::DictionaryValue* theme_value,
// The value may be a dictionary of scales and files paths.
// Or the value may be a file path, in which case a scale
// of 100% is assumed.
- if (iter.value().IsType(base::Value::TYPE_DICTIONARY)) {
+ if (iter.value().IsType(base::Value::Type::DICTIONARY)) {
const base::DictionaryValue* inner_value = NULL;
if (iter.value().GetAsDictionary(&inner_value)) {
for (base::DictionaryValue::Iterator inner_iter(*inner_value);
!inner_iter.IsAtEnd(); inner_iter.Advance()) {
- if (!inner_iter.value().IsType(base::Value::TYPE_STRING)) {
+ if (!inner_iter.value().IsType(base::Value::Type::STRING)) {
*error = base::ASCIIToUTF16(errors::kInvalidThemeImages);
return false;
}
@@ -46,7 +46,7 @@ bool LoadImages(const base::DictionaryValue* theme_value,
*error = base::ASCIIToUTF16(errors::kInvalidThemeImages);
return false;
}
- } else if (!iter.value().IsType(base::Value::TYPE_STRING)) {
+ } else if (!iter.value().IsType(base::Value::Type::STRING)) {
*error = base::ASCIIToUTF16(errors::kInvalidThemeImages);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698