Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: content/browser/devtools/protocol_string.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol_string.cc
diff --git a/content/browser/devtools/protocol_string.cc b/content/browser/devtools/protocol_string.cc
index 702bed219e5b79b871b6040cbfbc484c34ef0107..7c15d1a09e22af8a7264165a364bfe0aca1e3ed9 100644
--- a/content/browser/devtools/protocol_string.cc
+++ b/content/browser/devtools/protocol_string.cc
@@ -16,29 +16,29 @@ std::unique_ptr<protocol::Value> toProtocolValue(
const base::Value* value, int depth) {
if (!value || !depth)
return nullptr;
- if (value->IsType(base::Value::TYPE_NULL))
+ if (value->IsType(base::Value::Type::NONE))
return protocol::Value::null();
- if (value->IsType(base::Value::TYPE_BOOLEAN)) {
+ if (value->IsType(base::Value::Type::BOOLEAN)) {
bool inner;
value->GetAsBoolean(&inner);
return protocol::FundamentalValue::create(inner);
}
- if (value->IsType(base::Value::TYPE_INTEGER)) {
+ if (value->IsType(base::Value::Type::INTEGER)) {
int inner;
value->GetAsInteger(&inner);
return protocol::FundamentalValue::create(inner);
}
- if (value->IsType(base::Value::TYPE_DOUBLE)) {
+ if (value->IsType(base::Value::Type::DOUBLE)) {
double inner;
value->GetAsDouble(&inner);
return protocol::FundamentalValue::create(inner);
}
- if (value->IsType(base::Value::TYPE_STRING)) {
+ if (value->IsType(base::Value::Type::STRING)) {
std::string inner;
value->GetAsString(&inner);
return protocol::StringValue::create(inner);
}
- if (value->IsType(base::Value::TYPE_LIST)) {
+ if (value->IsType(base::Value::Type::LIST)) {
const base::ListValue* list = nullptr;
value->GetAsList(&list);
std::unique_ptr<protocol::ListValue> result = protocol::ListValue::create();
@@ -52,7 +52,7 @@ std::unique_ptr<protocol::Value> toProtocolValue(
}
return std::move(result);
}
- if (value->IsType(base::Value::TYPE_DICTIONARY)) {
+ if (value->IsType(base::Value::Type::DICTIONARY)) {
const base::DictionaryValue* dictionary = nullptr;
value->GetAsDictionary(&dictionary);
std::unique_ptr<protocol::DictionaryValue> result =

Powered by Google App Engine
This is Rietveld 408576698