chrome/browser/extensions/api/management/management_api_browsertest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api_browsertest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_api_browsertest.cc b/chrome/browser/extensions/api/management/management_api_browsertest.cc

index 15a39a50200b8637d17a769a5cbe90aed74d57cb..75c9f0261411b050e11e396fecf40b96e5d0c851 100644

--- a/chrome/browser/extensions/api/management/management_api_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_api_browsertest.cc

@@ -244,7 +244,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,

std::unique_ptr<base::Value> result(util::RunFunctionAndReturnSingleResult(

function.get(), base::StringPrintf("[\"%s\"]", kId), browser()));

ASSERT_TRUE(result.get() != NULL);

- ASSERT_TRUE(result->IsType(base::Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(result->IsType(base::Value::Type::DICTIONARY));

base::DictionaryValue* dict =

static_cast<base::DictionaryValue*>(result.get());

std::string reason;