Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chromeos/dbus/shill_client_helper.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/dbus/shill_ipconfig_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_client_helper.cc
diff --git a/chromeos/dbus/shill_client_helper.cc b/chromeos/dbus/shill_client_helper.cc
index 647c47321ba377936b4af561c4893087e607201a..46ba9b5b8f5b26d72fe66154099b5f1ba1200f21 100644
--- a/chromeos/dbus/shill_client_helper.cc
+++ b/chromeos/dbus/shill_client_helper.cc
@@ -442,7 +442,7 @@ void AppendValueDataAsVariantInternal(dbus::MessageWriter* writer,
DictionaryType dictionary_type) {
// Support basic types and string-to-string dictionary.
switch (value.GetType()) {
- case base::Value::TYPE_DICTIONARY: {
+ case base::Value::Type::DICTIONARY: {
const base::DictionaryValue* dictionary = NULL;
value.GetAsDictionary(&dictionary);
if (dictionary_type == DICTIONARY_TYPE_STRING) {
@@ -456,7 +456,7 @@ void AppendValueDataAsVariantInternal(dbus::MessageWriter* writer,
}
break;
}
- case base::Value::TYPE_LIST: {
+ case base::Value::Type::LIST: {
const base::ListValue* list = NULL;
value.GetAsList(&list);
dbus::MessageWriter variant_writer(NULL);
@@ -475,10 +475,10 @@ void AppendValueDataAsVariantInternal(dbus::MessageWriter* writer,
writer->CloseContainer(&variant_writer);
break;
}
- case base::Value::TYPE_BOOLEAN:
- case base::Value::TYPE_INTEGER:
- case base::Value::TYPE_DOUBLE:
- case base::Value::TYPE_STRING:
+ case base::Value::Type::BOOLEAN:
+ case base::Value::Type::INTEGER:
+ case base::Value::Type::DOUBLE:
+ case base::Value::Type::STRING:
dbus::AppendBasicTypeValueDataAsVariant(writer, value);
break;
default:
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/dbus/shill_ipconfig_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698