components/dom_distiller/core/distiller_page.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/distiller_page.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/dom_distiller/core/distiller_page.cc

diff --git a/components/dom_distiller/core/distiller_page.cc b/components/dom_distiller/core/distiller_page.cc

index fb115d8e8f78e84ac6cb8c36010595e846d66038..7e66e453dc2bb28b427f9586f612a7e936e0a75d 100644

--- a/components/dom_distiller/core/distiller_page.cc

+++ b/components/dom_distiller/core/distiller_page.cc

@@ -94,7 +94,7 @@ void DistillerPage::OnDistillationDone(const GURL& page_url,

std::unique_ptr<dom_distiller::proto::DomDistillerResult> distiller_result(

new dom_distiller::proto::DomDistillerResult());

bool found_content;

- if (value->IsType(base::Value::TYPE_NULL)) {

+ if (value->IsType(base::Value::Type::NONE)) {

found_content = false;

} else {

found_content =