Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/libaddressinput/chromium/json.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/preferences/public/cpp/tests/pref_observer_store_unittest.cc ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/chromium/json.cc
diff --git a/third_party/libaddressinput/chromium/json.cc b/third_party/libaddressinput/chromium/json.cc
index 887d55df8f9275b3ba4cb9976948a9f841fd4cc8..fbfcb3a9d075c40f6323488d2f8717d74062a17f 100644
--- a/third_party/libaddressinput/chromium/json.cc
+++ b/third_party/libaddressinput/chromium/json.cc
@@ -29,7 +29,7 @@ namespace {
// of the standalone library use char* rather than std::string.
::std::unique_ptr<const base::Value> parsed(
base::JSONReader::Read(json.c_str()));
- *parser_error = !parsed || !parsed->IsType(base::Value::TYPE_DICTIONARY);
+ *parser_error = !parsed || !parsed->IsType(base::Value::Type::DICTIONARY);
if (*parser_error)
result.reset(new base::DictionaryValue);
@@ -57,7 +57,7 @@ class Json::JsonImpl {
if (sub_dicts_.empty()) {
for (base::DictionaryValue::Iterator it(dict_); !it.IsAtEnd();
it.Advance()) {
- if (it.value().IsType(base::Value::TYPE_DICTIONARY)) {
+ if (it.value().IsType(base::Value::Type::DICTIONARY)) {
const base::DictionaryValue* sub_dict = NULL;
it.value().GetAsDictionary(&sub_dict);
owned_sub_dicts_.push_back(
« no previous file with comments | « services/preferences/public/cpp/tests/pref_observer_store_unittest.cc ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698