chromeos/geolocation/simple_geolocation_request.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/geolocation/simple_geolocation_request.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/geolocation/simple_geolocation_request.cc

diff --git a/chromeos/geolocation/simple_geolocation_request.cc b/chromeos/geolocation/simple_geolocation_request.cc

index cb10cd6618b6209599a731f5c6c46eaa7edf9eee..1369458218cb3d21772ad81e43723fc673fe6409 100644

--- a/chromeos/geolocation/simple_geolocation_request.cc

+++ b/chromeos/geolocation/simple_geolocation_request.cc

@@ -199,7 +199,8 @@ bool ParseServerResponse(const GURL& server_url,

PrintGeolocationError(

server_url,

"Unexpected response type : " +

- base::StringPrintf("%u", response_value->GetType()),

+ base::StringPrintf(

+ "%u", static_cast<unsigned int>(response_value->GetType())),

position);

RecordUmaEvent(SIMPLE_GEOLOCATION_REQUEST_EVENT_RESPONSE_MALFORMED);

return false;

« no previous file with comments | « chromeos/dbus/shill_ipconfig_client.cc ('k') | chromeos/network/network_sms_handler.cc » ('j') | no next file with comments »