chrome/browser/apps/drive/drive_app_mapping.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/drive/drive_app_mapping.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/drive/drive_app_mapping.cc

diff --git a/chrome/browser/apps/drive/drive_app_mapping.cc b/chrome/browser/apps/drive/drive_app_mapping.cc

index 73b08b5abe963e52b85918317cf6f1ff4b61ba86..ea8fb0f8e5ce6d47f65a199c44f7bcccef7a0f0d 100644

--- a/chrome/browser/apps/drive/drive_app_mapping.cc

+++ b/chrome/browser/apps/drive/drive_app_mapping.cc

@@ -84,7 +84,7 @@ std::string DriveAppMapping::GetDriveApp(

it.Advance()) {

const base::DictionaryValue* info_dict;

std::string value_string;

- DCHECK(it.value().IsType(base::Value::TYPE_DICTIONARY));

+ DCHECK(it.value().IsType(base::Value::Type::DICTIONARY));

if (it.value().GetAsDictionary(&info_dict) &&

info_dict->GetStringWithoutPathExpansion(kKeyChromeApp,

&value_string) &&

@@ -104,7 +104,7 @@ bool DriveAppMapping::IsChromeAppGenerated(