extensions/common/features/json_feature_provider_source.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/json_feature_provider_source.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/json_feature_provider_source.cc

diff --git a/extensions/common/features/json_feature_provider_source.cc b/extensions/common/features/json_feature_provider_source.cc

index 94064a171fc1d28e48e4a44b3540d7fe5b14d2d8..caf091431d06e81ddc3b02137d7a18c13afb5bf0 100644

--- a/extensions/common/features/json_feature_provider_source.cc

+++ b/extensions/common/features/json_feature_provider_source.cc

@@ -31,7 +31,7 @@ void JSONFeatureProviderSource::LoadJSON(int resource_id) {

std::unique_ptr<base::DictionaryValue> value_as_dict;

if (value) {

- CHECK(value->IsType(base::Value::TYPE_DICTIONARY)) << name_;

+ CHECK(value->IsType(base::Value::Type::DICTIONARY)) << name_;

value_as_dict = base::DictionaryValue::From(std::move(value));

} else {

// There was some error loading the features file.

« no previous file with comments | « extensions/common/extension_api.cc ('k') | extensions/common/file_util.cc » ('j') | no next file with comments »