Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
index 54fa9c161b19d0f020115afe4dfdbf414a63f4ca..928be7553af0184e9947124c245bda59e08595a4 100644
--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
@@ -59,7 +59,7 @@ bool IsOwnerInTests(const std::string& user_id) {
return false;
}
const base::Value* value = CrosSettings::Get()->GetPref(kDeviceOwner);
- if (!value || value->GetType() != base::Value::TYPE_STRING)
+ if (!value || value->GetType() != base::Value::Type::STRING)
return false;
return static_cast<const base::StringValue*>(value)->GetString() == user_id;
}
@@ -275,7 +275,7 @@ bool OwnerSettingsServiceChromeOS::AppendToList(const std::string& setting,
const base::Value& value) {
DCHECK(thread_checker_.CalledOnValidThread());
const base::Value* old_value = CrosSettings::Get()->GetPref(setting);
- if (old_value && !old_value->IsType(base::Value::TYPE_LIST))
+ if (old_value && !old_value->IsType(base::Value::Type::LIST))
return false;
std::unique_ptr<base::ListValue> new_value(
old_value ? static_cast<const base::ListValue*>(old_value)->DeepCopy()
@@ -288,7 +288,7 @@ bool OwnerSettingsServiceChromeOS::RemoveFromList(const std::string& setting,
const base::Value& value) {
DCHECK(thread_checker_.CalledOnValidThread());
const base::Value* old_value = CrosSettings::Get()->GetPref(setting);
- if (old_value && !old_value->IsType(base::Value::TYPE_LIST))
+ if (old_value && !old_value->IsType(base::Value::Type::LIST))
return false;
std::unique_ptr<base::ListValue> new_value(
old_value ? static_cast<const base::ListValue*>(old_value)->DeepCopy()

Powered by Google App Engine
This is Rietveld 408576698