Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: components/policy/core/common/mac_util_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/mac_util_unittest.cc
diff --git a/components/policy/core/common/mac_util_unittest.cc b/components/policy/core/common/mac_util_unittest.cc
index c082dafa509c4d00c1aefe211576863638e930e1..b96e298b41f377e597fbfd4019b4f7140669245a 100644
--- a/components/policy/core/common/mac_util_unittest.cc
+++ b/components/policy/core/common/mac_util_unittest.cc
@@ -18,26 +18,26 @@ namespace policy {
TEST(PolicyMacUtilTest, PropertyToValue) {
base::DictionaryValue root;
- // base::Value::TYPE_NULL
+ // base::Value::Type::NONE
root.Set("null", base::Value::CreateNullValue());
- // base::Value::TYPE_BOOLEAN
+ // base::Value::Type::BOOLEAN
root.SetBoolean("false", false);
root.SetBoolean("true", true);
- // base::Value::TYPE_INTEGER
+ // base::Value::Type::INTEGER
root.SetInteger("int", 123);
root.SetInteger("zero", 0);
- // base::Value::TYPE_DOUBLE
+ // base::Value::Type::DOUBLE
root.SetDouble("double", 123.456);
root.SetDouble("zerod", 0.0);
- // base::Value::TYPE_STRING
+ // base::Value::Type::STRING
root.SetString("string", "the fox jumps over something");
root.SetString("empty", "");
- // base::Value::TYPE_LIST
+ // base::Value::Type::LIST
base::ListValue list;
root.Set("emptyl", list.DeepCopy());
for (base::DictionaryValue::Iterator it(root); !it.IsAtEnd(); it.Advance())
@@ -46,7 +46,7 @@ TEST(PolicyMacUtilTest, PropertyToValue) {
list.Append(root.DeepCopy());
root.Set("list", list.DeepCopy());
- // base::Value::TYPE_DICTIONARY
+ // base::Value::Type::DICTIONARY
base::DictionaryValue dict;
root.Set("emptyd", dict.DeepCopy());
// Very meta.

Powered by Google App Engine
This is Rietveld 408576698