Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/input_method/component_extension_ime_manager_i mpl.h" 5 #include "chrome/browser/chromeos/input_method/component_extension_ime_manager_i mpl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 if (!dict.GetString(extensions::manifest_keys::kId, &out->engine_id)) 210 if (!dict.GetString(extensions::manifest_keys::kId, &out->engine_id))
211 return false; 211 return false;
212 if (!dict.GetString(extensions::manifest_keys::kName, &out->display_name)) 212 if (!dict.GetString(extensions::manifest_keys::kName, &out->display_name))
213 return false; 213 return false;
214 if (!dict.GetString(extensions::manifest_keys::kIndicator, &out->indicator)) 214 if (!dict.GetString(extensions::manifest_keys::kIndicator, &out->indicator))
215 out->indicator = ""; 215 out->indicator = "";
216 216
217 std::set<std::string> languages; 217 std::set<std::string> languages;
218 const base::Value* language_value = NULL; 218 const base::Value* language_value = NULL;
219 if (dict.Get(extensions::manifest_keys::kLanguage, &language_value)) { 219 if (dict.Get(extensions::manifest_keys::kLanguage, &language_value)) {
220 if (language_value->GetType() == base::Value::TYPE_STRING) { 220 if (language_value->GetType() == base::Value::Type::STRING) {
221 std::string language_str; 221 std::string language_str;
222 language_value->GetAsString(&language_str); 222 language_value->GetAsString(&language_str);
223 languages.insert(language_str); 223 languages.insert(language_str);
224 } else if (language_value->GetType() == base::Value::TYPE_LIST) { 224 } else if (language_value->GetType() == base::Value::Type::LIST) {
225 const base::ListValue* language_list = NULL; 225 const base::ListValue* language_list = NULL;
226 language_value->GetAsList(&language_list); 226 language_value->GetAsList(&language_list);
227 for (size_t j = 0; j < language_list->GetSize(); ++j) { 227 for (size_t j = 0; j < language_list->GetSize(); ++j) {
228 std::string language_str; 228 std::string language_str;
229 if (language_list->GetString(j, &language_str)) 229 if (language_list->GetString(j, &language_str))
230 languages.insert(language_str); 230 languages.insert(language_str);
231 } 231 }
232 } 232 }
233 } 233 }
234 DCHECK(!languages.empty()); 234 DCHECK(!languages.empty());
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 342
343 ComponentExtensionEngine engine; 343 ComponentExtensionEngine engine;
344 ReadEngineComponent(component_ime, *dictionary, &engine); 344 ReadEngineComponent(component_ime, *dictionary, &engine);
345 component_ime.engines.push_back(engine); 345 component_ime.engines.push_back(engine);
346 } 346 }
347 out_imes->push_back(component_ime); 347 out_imes->push_back(component_ime);
348 } 348 }
349 } 349 }
350 350
351 } // namespace chromeos 351 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/extensions/echo_private_apitest.cc ('k') | chrome/browser/chromeos/mobile/mobile_activator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698