Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: google_apis/drive/drive_api_parser_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/utility/unpacker.cc ('k') | google_apis/gaia/gaia_auth_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/drive_api_parser_unittest.cc
diff --git a/google_apis/drive/drive_api_parser_unittest.cc b/google_apis/drive/drive_api_parser_unittest.cc
index 712e0ec636397d6559535eb4c90717c424eff542..01f930cec0f66db31d365e5c3b5913ffdfbabdc0 100644
--- a/google_apis/drive/drive_api_parser_unittest.cc
+++ b/google_apis/drive/drive_api_parser_unittest.cc
@@ -19,7 +19,7 @@ TEST(DriveAPIParserTest, AboutResourceParser) {
test_util::LoadJSONFile("drive/about.json");
ASSERT_TRUE(document.get());
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, document->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, document->GetType());
std::unique_ptr<AboutResource> resource(new AboutResource());
EXPECT_TRUE(resource->Parse(*document));
@@ -36,7 +36,7 @@ TEST(DriveAPIParserTest, AppListParser) {
test_util::LoadJSONFile("drive/applist.json");
ASSERT_TRUE(document.get());
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, document->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, document->GetType());
std::unique_ptr<AppList> applist(new AppList);
EXPECT_TRUE(applist->Parse(*document));
@@ -114,7 +114,7 @@ TEST(DriveAPIParserTest, FileListParser) {
test_util::LoadJSONFile("drive/filelist.json");
ASSERT_TRUE(document.get());
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, document->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, document->GetType());
std::unique_ptr<FileList> filelist(new FileList);
EXPECT_TRUE(filelist->Parse(*document));
@@ -216,7 +216,7 @@ TEST(DriveAPIParserTest, ChangeListParser) {
test_util::LoadJSONFile("drive/changelist.json");
ASSERT_TRUE(document.get());
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, document->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, document->GetType());
std::unique_ptr<ChangeList> changelist(new ChangeList);
EXPECT_TRUE(changelist->Parse(*document));
« no previous file with comments | « extensions/utility/unpacker.cc ('k') | google_apis/gaia/gaia_auth_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698