Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/drive/drive_app_mapping.cc ('k') | chrome/browser/bookmarks/bookmark_html_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_settings_helper.cc
diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc
index c93f08a677337157c77947643bd5b28f5076ca4d..f11d325306df5f2a007bb2ad8ce9a783bf0d2744 100644
--- a/chrome/browser/banners/app_banner_settings_helper.cc
+++ b/chrome/browser/banners/app_banner_settings_helper.cc
@@ -354,7 +354,7 @@ void AppBannerSettingsHelper::RecordBannerCouldShowEvent(
// the times are converted to local dates.
base::Time date = BucketTimeToResolution(time, gMinimumMinutesBetweenVisits);
for (auto it = could_show_list->begin(); it != could_show_list->end();) {
- if ((*it)->IsType(base::Value::TYPE_DICTIONARY)) {
+ if ((*it)->IsType(base::Value::Type::DICTIONARY)) {
base::DictionaryValue* internal_value;
double internal_date;
(*it)->GetAsDictionary(&internal_value);
@@ -496,7 +496,7 @@ AppBannerSettingsHelper::GetCouldShowBannerEvents(
return result;
for (const auto& value : *could_show_list) {
- if (value->IsType(base::Value::TYPE_DICTIONARY)) {
+ if (value->IsType(base::Value::Type::DICTIONARY)) {
base::DictionaryValue* internal_value;
double internal_date = 0;
value->GetAsDictionary(&internal_value);
@@ -581,7 +581,7 @@ bool AppBannerSettingsHelper::WasLaunchedRecently(Profile* profile,
// homescreen recently, return true.
for (base::DictionaryValue::Iterator it(*origin_dict); !it.IsAtEnd();
it.Advance()) {
- if (it.value().IsType(base::Value::TYPE_DICTIONARY)) {
+ if (it.value().IsType(base::Value::Type::DICTIONARY)) {
const base::DictionaryValue* value;
it.value().GetAsDictionary(&value);
« no previous file with comments | « chrome/browser/apps/drive/drive_app_mapping.cc ('k') | chrome/browser/bookmarks/bookmark_html_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698