Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: content/browser/devtools/protocol/tracing_handler.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_protocol_handler.cc ('k') | content/browser/devtools/protocol_string.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/tracing_handler.cc
diff --git a/content/browser/devtools/protocol/tracing_handler.cc b/content/browser/devtools/protocol/tracing_handler.cc
index ea5c2d44be4ed9bdd4684102a3afc8487b7437c7..eb6f29cacbe8aaa93e24fc0854981db228200daf 100644
--- a/content/browser/devtools/protocol/tracing_handler.cc
+++ b/content/browser/devtools/protocol/tracing_handler.cc
@@ -194,7 +194,7 @@ void TracingHandler::Start(Maybe<std::string> categories,
if (config.isJust()) {
std::unique_ptr<base::Value> value =
protocol::toBaseValue(config.fromJust()->toValue().get(), 1000);
- if (value && value->IsType(base::Value::TYPE_DICTIONARY)) {
+ if (value && value->IsType(base::Value::Type::DICTIONARY)) {
trace_config = GetTraceConfigFromDevToolsConfig(
*static_cast<base::DictionaryValue*>(value.get()));
}
@@ -345,7 +345,7 @@ bool TracingHandler::IsStartupTracingActive() {
base::trace_event::TraceConfig TracingHandler::GetTraceConfigFromDevToolsConfig(
const base::DictionaryValue& devtools_config) {
std::unique_ptr<base::Value> value = ConvertDictKeyStyle(devtools_config);
- DCHECK(value && value->IsType(base::Value::TYPE_DICTIONARY));
+ DCHECK(value && value->IsType(base::Value::Type::DICTIONARY));
std::unique_ptr<base::DictionaryValue> tracing_dict(
static_cast<base::DictionaryValue*>(value.release()));
« no previous file with comments | « content/browser/devtools/devtools_protocol_handler.cc ('k') | content/browser/devtools/protocol_string.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698