Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: components/prefs/pref_member.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/prefs/overlay_user_pref_store_unittest.cc ('k') | components/prefs/pref_registry.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/prefs/pref_member.h" 5 #include "components/prefs/pref_member.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 } 124 }
125 125
126 void PrefMemberBase::Internal::MoveToThread( 126 void PrefMemberBase::Internal::MoveToThread(
127 scoped_refptr<SingleThreadTaskRunner> task_runner) { 127 scoped_refptr<SingleThreadTaskRunner> task_runner) {
128 CheckOnCorrectThread(); 128 CheckOnCorrectThread();
129 thread_task_runner_ = std::move(task_runner); 129 thread_task_runner_ = std::move(task_runner);
130 } 130 }
131 131
132 bool PrefMemberVectorStringUpdate(const base::Value& value, 132 bool PrefMemberVectorStringUpdate(const base::Value& value,
133 std::vector<std::string>* string_vector) { 133 std::vector<std::string>* string_vector) {
134 if (!value.IsType(base::Value::TYPE_LIST)) 134 if (!value.IsType(base::Value::Type::LIST))
135 return false; 135 return false;
136 const base::ListValue* list = static_cast<const base::ListValue*>(&value); 136 const base::ListValue* list = static_cast<const base::ListValue*>(&value);
137 137
138 std::vector<std::string> local_vector; 138 std::vector<std::string> local_vector;
139 for (base::ListValue::const_iterator it = list->begin(); 139 for (base::ListValue::const_iterator it = list->begin();
140 it != list->end(); ++it) { 140 it != list->end(); ++it) {
141 std::string string_value; 141 std::string string_value;
142 if (!(*it)->GetAsString(&string_value)) 142 if (!(*it)->GetAsString(&string_value))
143 return false; 143 return false;
144 144
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 base::ListValue list_value; 214 base::ListValue list_value;
215 list_value.AppendStrings(value); 215 list_value.AppendStrings(value);
216 prefs()->Set(pref_name(), list_value); 216 prefs()->Set(pref_name(), list_value);
217 } 217 }
218 218
219 template <> 219 template <>
220 bool PrefMember<std::vector<std::string> >::Internal::UpdateValueInternal( 220 bool PrefMember<std::vector<std::string> >::Internal::UpdateValueInternal(
221 const base::Value& value) const { 221 const base::Value& value) const {
222 return subtle::PrefMemberVectorStringUpdate(value, &value_); 222 return subtle::PrefMemberVectorStringUpdate(value, &value_);
223 } 223 }
OLDNEW
« no previous file with comments | « components/prefs/overlay_user_pref_store_unittest.cc ('k') | components/prefs/pref_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698