Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: extensions/renderer/activity_log_converter_strategy_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_handlers/background_info.cc ('k') | extensions/renderer/event_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/activity_log_converter_strategy_unittest.cc
diff --git a/extensions/renderer/activity_log_converter_strategy_unittest.cc b/extensions/renderer/activity_log_converter_strategy_unittest.cc
index 2dfcd8cd12d8b0953292e94b91cedb52ea2a24f8..5d82de949aaf46eb82eb48031b7b8604d6656eb1 100644
--- a/extensions/renderer/activity_log_converter_strategy_unittest.cc
+++ b/extensions/renderer/activity_log_converter_strategy_unittest.cc
@@ -33,7 +33,7 @@ class ActivityLogConverterStrategyTest : public testing::Test {
testing::AssertionResult VerifyNull(v8::Local<v8::Value> v8_value) {
std::unique_ptr<base::Value> value(
converter_->FromV8Value(v8_value, context()));
- if (value->IsType(base::Value::TYPE_NULL))
+ if (value->IsType(base::Value::Type::NONE))
return testing::AssertionSuccess();
return testing::AssertionFailure();
}
@@ -43,7 +43,7 @@ class ActivityLogConverterStrategyTest : public testing::Test {
bool out;
std::unique_ptr<base::Value> value(
converter_->FromV8Value(v8_value, context()));
- if (value->IsType(base::Value::TYPE_BOOLEAN)
+ if (value->IsType(base::Value::Type::BOOLEAN)
&& value->GetAsBoolean(&out)
&& out == expected)
return testing::AssertionSuccess();
@@ -55,7 +55,7 @@ class ActivityLogConverterStrategyTest : public testing::Test {
int out;
std::unique_ptr<base::Value> value(
converter_->FromV8Value(v8_value, context()));
- if (value->IsType(base::Value::TYPE_INTEGER)
+ if (value->IsType(base::Value::Type::INTEGER)
&& value->GetAsInteger(&out)
&& out == expected)
return testing::AssertionSuccess();
@@ -67,7 +67,7 @@ class ActivityLogConverterStrategyTest : public testing::Test {
double out;
std::unique_ptr<base::Value> value(
converter_->FromV8Value(v8_value, context()));
- if (value->IsType(base::Value::TYPE_DOUBLE)
+ if (value->IsType(base::Value::Type::DOUBLE)
&& value->GetAsDouble(&out)
&& out == expected)
return testing::AssertionSuccess();
@@ -79,7 +79,7 @@ class ActivityLogConverterStrategyTest : public testing::Test {
std::string out;
std::unique_ptr<base::Value> value(
converter_->FromV8Value(v8_value, context()));
- if (value->IsType(base::Value::TYPE_STRING)
+ if (value->IsType(base::Value::Type::STRING)
&& value->GetAsString(&out)
&& out == expected)
return testing::AssertionSuccess();
« no previous file with comments | « extensions/common/manifest_handlers/background_info.cc ('k') | extensions/renderer/event_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698