extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/declarative_api.cc ('k') | extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

index f3aa8d35e0803e84528f12e8fccd7394d9f6a3c3..72fc2f71c61750a8c0c245d3e291c58f134ce521 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

@@ -507,7 +507,7 @@ HeaderMatcher::HeaderMatchTest::Create(const base::DictionaryValue* tests) {

std::vector<std::unique_ptr<const StringMatchTest>>* tests =

is_name ? &name_match : &value_match;

switch (content->GetType()) {

- case base::Value::TYPE_LIST: {

+ case base::Value::Type::LIST: {

const base::ListValue* list = NULL;

CHECK(content->GetAsList(&list));

for (const auto& it : *list) {

@@ -515,7 +515,7 @@ HeaderMatcher::HeaderMatchTest::Create(const base::DictionaryValue* tests) {

}

break;

}

- case base::Value::TYPE_STRING: {

+ case base::Value::Type::STRING: {

tests->push_back(

StringMatchTest::Create(*content, match_type, !is_name));

break;