Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: chrome/browser/policy/javascript_policy_handler.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/javascript_policy_handler.cc
diff --git a/chrome/browser/policy/javascript_policy_handler.cc b/chrome/browser/policy/javascript_policy_handler.cc
index edd65f43d33bea767958a6281b1c18adfcc6145c..8f2194ad581807f9653f814eec4a5705e3ab000a 100644
--- a/chrome/browser/policy/javascript_policy_handler.cc
+++ b/chrome/browser/policy/javascript_policy_handler.cc
@@ -27,14 +27,14 @@ bool JavascriptPolicyHandler::CheckPolicySettings(const PolicyMap& policies,
policies.GetValue(key::kDefaultJavaScriptSetting);
if (javascript_enabled &&
- !javascript_enabled->IsType(base::Value::TYPE_BOOLEAN)) {
+ !javascript_enabled->IsType(base::Value::Type::BOOLEAN)) {
errors->AddError(key::kJavascriptEnabled, IDS_POLICY_TYPE_ERROR,
- base::Value::GetTypeName(base::Value::TYPE_BOOLEAN));
+ base::Value::GetTypeName(base::Value::Type::BOOLEAN));
}
- if (default_setting && !default_setting->IsType(base::Value::TYPE_INTEGER)) {
+ if (default_setting && !default_setting->IsType(base::Value::Type::INTEGER)) {
errors->AddError(key::kDefaultJavaScriptSetting, IDS_POLICY_TYPE_ERROR,
- base::Value::GetTypeName(base::Value::TYPE_INTEGER));
+ base::Value::GetTypeName(base::Value::Type::INTEGER));
}
if (javascript_enabled && default_setting) {

Powered by Google App Engine
This is Rietveld 408576698