Make base::Value::TYPE a scoped enum.

components/policy/core/common/mac_util_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/mac_util.h"
 
 #include <CoreFoundation/CoreFoundation.h>
 
 #include <memory>
 
 #include "base/mac/scoped_cftyperef.h"
 #include "base/values.h"
 #include "components/policy/core/common/policy_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 
 TEST(PolicyMacUtilTest, PropertyToValue) {
   base::DictionaryValue root;
 
-  // base::Value::TYPE_NULL
+  // base::Value::Type::NONE
   root.Set("null", base::Value::CreateNullValue());
 
-  // base::Value::TYPE_BOOLEAN
+  // base::Value::Type::BOOLEAN
   root.SetBoolean("false", false);
   root.SetBoolean("true", true);
 
-  // base::Value::TYPE_INTEGER
+  // base::Value::Type::INTEGER
   root.SetInteger("int", 123);
   root.SetInteger("zero", 0);
 
-  // base::Value::TYPE_DOUBLE
+  // base::Value::Type::DOUBLE
   root.SetDouble("double", 123.456);
   root.SetDouble("zerod", 0.0);
 
-  // base::Value::TYPE_STRING
+  // base::Value::Type::STRING
   root.SetString("string", "the fox jumps over something");
   root.SetString("empty", "");
 
-  // base::Value::TYPE_LIST
+  // base::Value::Type::LIST
   base::ListValue list;
   root.Set("emptyl", list.DeepCopy());
   for (base::DictionaryValue::Iterator it(root); !it.IsAtEnd(); it.Advance())
     list.Append(it.value().DeepCopy());
   EXPECT_EQ(root.size(), list.GetSize());
   list.Append(root.DeepCopy());
   root.Set("list", list.DeepCopy());
 
-  // base::Value::TYPE_DICTIONARY
+  // base::Value::Type::DICTIONARY
   base::DictionaryValue dict;
   root.Set("emptyd", dict.DeepCopy());
   // Very meta.
   root.Set("dict", root.DeepCopy());
 
   base::ScopedCFTypeRef<CFPropertyListRef> property(ValueToProperty(root));
   ASSERT_TRUE(property);
   std::unique_ptr<base::Value> value = PropertyToValue(property);
   ASSERT_TRUE(value);
   EXPECT_TRUE(root.Equals(value.get()));
 }
 
 }  // namespace policy