chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc

diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc

index e38c95bc7c784ce7754eb7f9397e9ff62c32f3fb..6d0d2f32a628bd512571832d8981b85b5ebfa44c 100644

--- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc

+++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc

@@ -579,7 +579,7 @@ TEST_F(EasyUnlockPrivateApiTest, GetRemoteDevicesExperimental) {

extensions::api_test_utils::RunFunctionAndReturnSingleResult(

function.get(), "[]", profile()));

ASSERT_TRUE(value.get());

- ASSERT_EQ(base::Value::TYPE_LIST, value->GetType());

+ ASSERT_EQ(base::Value::Type::LIST, value->GetType());

base::ListValue* list_value = static_cast<base::ListValue*>(value.get());

EXPECT_EQ(2u, list_value->GetSize());

@@ -588,8 +588,8 @@ TEST_F(EasyUnlockPrivateApiTest, GetRemoteDevicesExperimental) {

base::Value* remote_device2;

ASSERT_TRUE(list_value->Get(0, &remote_device1));

ASSERT_TRUE(list_value->Get(1, &remote_device2));

- EXPECT_EQ(base::Value::TYPE_DICTIONARY, remote_device1->GetType());

- EXPECT_EQ(base::Value::TYPE_DICTIONARY, remote_device2->GetType());

+ EXPECT_EQ(base::Value::Type::DICTIONARY, remote_device1->GetType());

+ EXPECT_EQ(base::Value::Type::DICTIONARY, remote_device2->GetType());

std::string name1, name2;

EXPECT_TRUE(static_cast<base::DictionaryValue*>(remote_device1)

@@ -613,7 +613,7 @@ TEST_F(EasyUnlockPrivateApiTest, GetRemoteDevicesNonExperimental) {

extensions::api_test_utils::RunFunctionAndReturnSingleResult(

function.get(), "[]", profile()));

ASSERT_TRUE(value.get());

- ASSERT_EQ(base::Value::TYPE_LIST, value->GetType());

+ ASSERT_EQ(base::Value::Type::LIST, value->GetType());

base::ListValue* list_value = static_cast<base::ListValue*>(value.get());

EXPECT_EQ(0u, list_value->GetSize());

@@ -634,7 +634,7 @@ TEST_F(EasyUnlockPrivateApiTest, GetPermitAccessExperimental) {

extensions::api_test_utils::RunFunctionAndReturnSingleResult(

function.get(), "[]", profile()));

ASSERT_TRUE(value);

- ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());

+ ASSERT_EQ(base::Value::Type::DICTIONARY, value->GetType());

base::DictionaryValue* permit_access =

static_cast<base::DictionaryValue*>(value.get());