Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: content/browser/service_manager/merge_dictionary.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_manager/merge_dictionary.h" 5 #include "content/browser/service_manager/merge_dictionary.h"
6 6
7 namespace content { 7 namespace content {
8 8
9 void MergeDictionary(base::DictionaryValue* target, 9 void MergeDictionary(base::DictionaryValue* target,
10 const base::DictionaryValue* source) { 10 const base::DictionaryValue* source) {
11 for (base::DictionaryValue::Iterator it(*source); !it.IsAtEnd(); 11 for (base::DictionaryValue::Iterator it(*source); !it.IsAtEnd();
12 it.Advance()) { 12 it.Advance()) {
13 const base::Value* merge_value = &it.value(); 13 const base::Value* merge_value = &it.value();
14 // Check whether we have to merge dictionaries. 14 // Check whether we have to merge dictionaries.
15 if (merge_value->IsType(base::Value::TYPE_DICTIONARY)) { 15 if (merge_value->IsType(base::Value::Type::DICTIONARY)) {
16 base::DictionaryValue* sub_dict; 16 base::DictionaryValue* sub_dict;
17 if (target->GetDictionaryWithoutPathExpansion(it.key(), &sub_dict)) { 17 if (target->GetDictionaryWithoutPathExpansion(it.key(), &sub_dict)) {
18 MergeDictionary( 18 MergeDictionary(
19 sub_dict, 19 sub_dict,
20 static_cast<const base::DictionaryValue*>(merge_value)); 20 static_cast<const base::DictionaryValue*>(merge_value));
21 continue; 21 continue;
22 } 22 }
23 } 23 }
24 if (merge_value->IsType(base::Value::TYPE_LIST)) { 24 if (merge_value->IsType(base::Value::Type::LIST)) {
25 const base::ListValue* merge_list = nullptr; 25 const base::ListValue* merge_list = nullptr;
26 if (merge_value->GetAsList(&merge_list)) { 26 if (merge_value->GetAsList(&merge_list)) {
27 base::ListValue* target_list = nullptr; 27 base::ListValue* target_list = nullptr;
28 if (target->GetListWithoutPathExpansion(it.key(), &target_list)) { 28 if (target->GetListWithoutPathExpansion(it.key(), &target_list)) {
29 for (size_t i = 0; i < merge_list->GetSize(); ++i) { 29 for (size_t i = 0; i < merge_list->GetSize(); ++i) {
30 const base::Value* element = nullptr; 30 const base::Value* element = nullptr;
31 CHECK(merge_list->Get(i, &element)); 31 CHECK(merge_list->Get(i, &element));
32 target_list->Append(element->CreateDeepCopy()); 32 target_list->Append(element->CreateDeepCopy());
33 } 33 }
34 continue; 34 continue;
35 } 35 }
36 } 36 }
37 } 37 }
38 // All other cases: Make a copy and hook it up. 38 // All other cases: Make a copy and hook it up.
39 target->SetWithoutPathExpansion(it.key(), merge_value->DeepCopy()); 39 target->SetWithoutPathExpansion(it.key(), merge_value->DeepCopy());
40 } 40 }
41 } 41 }
42 42
43 } // namespace content 43 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698